Canteen Management

D21 tasks 1 and 2 done: three draft PRs opened against integration/canteen-v1 to give IPD/Admin/architecture something concrete to review instead of a prose proposal. nuvita-shared-kernel PR 4: IDietaryOrderReadContract shape. nuvita-shared-kernel PR 5: GetDietTypesAsync contract shape plus HTTP client. nuvita-admin PR 3: the DietType master entity, full service, migration, and the api internal diet-types endpoint, wired end to end on the Admin side. All three linked on ADR-0001 and ADR-0002 and on sprints.md. Full test suites green on both repos. Task 3 remaining: Navya sends the review request to IPD team, Admin team, and platform architecture naming these three PRs, asking for accept, reject, or changes-requested by end of day. That message is Navyas to send, not something I can do. Checkpoint per the week 5 plan: if no response by D23, escalate rather than stalling the week.

Correction per team direction: no PR for this stage. Closed the three draft PRs (nuvita-shared-kernel 4 and 5, nuvita-admin 3) without merging. The work stays exactly where it was -- pushed to feature branches, review happens directly against the branch, not a PR. Branches: nuvita-shared-kernel feat/canteen-dietary-order-contract and feat/canteen-diet-type-admin-contract, nuvita-admin feat/canteen-diet-type-master. Updated both ADRs and sprints.md to reference the branches instead of PR links. Nothing else changed -- same code, same tests, same green suites.

Built the real IPD-side implementation of IDietaryOrderReadContract, not just the shape -- nuvita-ipd branch feat/canteen-dietary-order-contract. DietaryOrderLookupService joins DietaryOrder to Admission for HospitalId and PatientId, since DietaryOrder itself carries neither. New InternalDietaryOrdersController at api/ipd/internal/dietary-orders, same pattern as the existing admission-lookup contract C2. 13 new tests, full IPD suite green at 1654 passed.

Caught and fixed a real bug while implementing: the kernel contract DTO had PatientId as non-nullable, but Admission.PatientId is nullable for an unidentified emergency admission, and DietaryOrderService.CreateAsync has no identified-patient check -- would have been a latent crash. Fixed on the nuvita-shared-kernel branch, same name.

Also found, not yet resolved: integration/canteen-v1 is stale against dev in both nuvita-shared-kernel and nuvita-ipd -- missing newer features nuvita-billing now depends on transitively, which broke a from-source build against it as-is. Worked around locally to verify the code is correct, then reset each branch back to a clean, scoped diff before pushing -- the stale integration branch itself needs a separate sync, flagged on ADR-0001, not something I folded into this branch.

All three branches (nuvita-shared-kernel feat/canteen-dietary-order-contract and feat/canteen-diet-type-admin-contract, nuvita-admin feat/canteen-diet-type-master, nuvita-ipd feat/canteen-dietary-order-contract) are pushed, no PRs, ready for direct branch review as the team asked.

D22 shipped 2026-10-06 (both tasks, TDD, full suite green):

• Task 1 — DietTypeMaster local fallback. DietType entity + DietTypeCatalog (5-min TTL, tenant-qualified cache), GET /api/canteen/diet-types (RequireCapability(Dietary) 402 + RequirePermission(canteen.diet_types.read) 403), read-only portal page at /dietary/diet-types (wired into route permissions, not yet into the v1 nav sidebar). nuvita-canteen-management branch feat/canteen-d22-diet-types, PR #5 -> dev. 486 unit + 609 integration tests green.

• Task 2 — Diet-order inbox first sync. DietaryOrderSnapshot (poll-reconciled, disposable mirror of an IPD order -- never the clinical order itself, never a second writable copy per ADR-0001) + DietOrderSyncService.SyncActiveAsync, upserts by OrderId. IDietaryOrderReadContract is a local placeholder copied field-for-field from nuvita-shared-kernel branch feat/canteen-dietary-order-contract (ADR-0001 still proposed, not on kernel dev yet) -- no production implementation registered, tests use a fake. 60s poll loop + GetChangedSinceAsync deferred to D23. nuvita-canteen-management branch feat/canteen-d22-dietary-order-sync, PR #6 -> dev. 475 unit + 601 integration tests green.

sprints.md updated (F3-1, F3-2 moved to in-progress) -- clinq-docs PR #13 -> dev.

Next: D23 -- 60s tray-sync poller (ADR-0004) + DietitianAssessment.

D23 shipped 2026-10-07 (both tasks, TDD, full suite green):

• Task 1 -- 60s tray-sync poller (ADR-0004). DietOrderPollJob (IHostedService) polls every active hospital (via IAdminServiceContract.GetHospitalsAsync) on every configured tenant, every CanteenManagement:IpdPollIntervalSeconds (default 60). First poll per hospital falls back to D22s SyncActiveAsync; every poll after uses the new SyncChangedSinceAsync. TenantScopedBackgroundService + BackgroundJobTenants copied from nuvita-ipds own Hosting folder. nuvita-canteen-management branch feat/canteen-d23-tray-sync-poller, PR #7 -> feat/canteen-d22-dietary-order-sync. 475 unit + 604 integration tests green.

• Task 2 -- DietitianAssessment. Immutable record of the Canteen-side review (ADR-0001). Accepted carries no change fields; ChangeRecommended requires RecommendedDietCode + RecommendationRationale, enforced in the constructor. Accepted.ServeFrom is a scheduling intent only -- no Tray/MealSheetLine row created (thats D24). POST /api/canteen/dietary/assessments, new permission key canteen.dietitian_assessments.create added to permission-keys.json. Portal review page at /dietary/orders/[orderId]. Deliberate tracked gap: DietaryOrderId is not verified against a synced DietaryOrderSnapshot yet -- flagged in the entitys own doc comment. nuvita-canteen-management branch feat/canteen-d23-dietitian-assessment, PR #8 -> feat/canteen-d23-tray-sync-poller. 485 unit + 618 integration tests green.

Incident during this work: GitHub Desktop silently switched the repo to dev mid-task and deleted (not just stashed) three new untracked files + a test folder I had just created on the D23 branch -- recovered by reconstructing them from this sessions own context, and switched to an isolated git worktree (.canteen-d23-worktree) for the rest of the days work to avoid it recurring. Memory feedback-github-desktop-collision.md updated with this more severe variant.

sprints.md updated (F3-2) -- clinq-docs branch docs/canteen-d22-sprints-update, PR #13 -> dev (still open, awaiting merge go-ahead).

Next: D24 -- MealSheet/MealSheetLine freeze + Tray FSM + allergy fail-closed path (the modules single most safety-critical test).

D24 shipped 2026-10-07 (both tasks, TDD, full suite green):

• Task 1 -- MealSheet freeze, irreversible. MealSheet.Freeze is one-way (Open -> Frozen only, a second freeze throws). RecordWardCountAsync feeds the sheets running totals while Open; the same call after freeze writes a separate IsLate addendum line (UNIQUE MealSheetId/WardId/DietTypeCode/IsLate) and leaves the frozen totals untouched. No auto-freeze/cut-off job yet -- only the invariant the plans step asked for. nuvita-canteen-management branch feat/canteen-d24-mealsheet-freeze, PR #9 -> feat/canteen-d23-dietitian-assessment. 490 unit + 623 integration tests green.

• Task 2 -- Tray FSM + allergy fail-closed at plating. This modules single most safety-critical path. PlateAsync calls EMRs GetPatientAllergiesAsync BEFORE any mutation -- an exception propagates untouched (tray stays Planned, no AllergySnapshot), an explicit empty list is a distinct recorded "[]". Ward/bed read live and snapshotted once at plating, never re-resolved; a transfer after plating audits instead of rewriting (HandleAdmissionTransferAsync). CollectAsync requires IntakePercent except RT feeds/skipped. Known platform gap, not introduced here: IAdmissionServiceContract has no HTTP implementation anywhere on the platform (confirmed against nuvita-shared-kernel -- HttpIpdServiceClient implements neither of its methods) -- left unregistered, same posture as D21s IDietaryOrderReadContract; does not weaken the fail-closed path itself. BedCode stored as the raw numeric id -- no Admin contract exposes a bed-level code yet. nuvita-canteen-management branch feat/canteen-d24-tray-allergy-fail-closed, PR #10 -> feat/canteen-d24-mealsheet-freeze. 498 unit + 630 integration tests green.

Bug found and fixed in the same branch: AddPatientServiceClient throws eagerly at startup without Emr:BaseUrl configured, which broke the whole CanteenApiFixture test host (224 failures) until a sentinel was added to the fixture.

sprints.md updated (F3-4, F3-5, F3-6) -- clinq-docs branch docs/canteen-d22-sprints-update, PR #13 -> dev (still open, awaiting merge go-ahead).

Next: D25 -- diet charge accrual (money path) + tray round portal page + write Week 6.

D25 shipped 2026-10-12 -- Week 5 is complete.

• Task 1 -- Diet charge accrual (money path). DietChargeAccrualService.PostAsync posts one DIET- line per (DietaryOrderId, ServiceDate), idempotent via a row-level check backed by the schema UNIQUE index. Depends on IAttendantChargeBillingContract, not the full IBillingServiceContract -- that narrower contract has no AtomicCreateBillAsync member at all, so the one-finalized-bill-per-charge incident is structurally unreachable, not just avoided by discipline. DietChargeAccrualJob (same shape as D23 poller) posts once per active order per hospital per tenant, resolving the daily rate from IDietTypeCatalog -- required merging D22 Task 1 (diet types, PR #5) into this branch, since the two D22 tasks had been built as sibling chains. nuvita-canteen-management branch feat/canteen-d25-diet-charge-accrual, PR #11. 509 unit + 652 integration tests green.

• Task 2 -- Tray round portal page (mobile surface). One tray per screen, large tap targets (spec Sec2.8: Android Chrome, portrait, one-handed, ward corridor). tray-round.ts pure forwardActionFor(status) drives the single forward action per screen, hiding it entirely for terminal states (Collected/Skipped/Returned). No TrayController exists yet to actually call -- queries/trays.ts shaped to match TrayDto/ITrayService exactly so wiring real routes later is a path change, not a redesign. nuvita-canteen-management branch feat/canteen-d25-tray-round-portal, PR #12. Portal: 422/422 tests, type-check clean.

• Task 3 -- Week 6 plan written. clinq-docs/modules/canteen-management/plans/2026-10-07-canteen-v1-week-6-tdd-plan.md. Per Week 5s own checkpoint instruction: ADR-0001/0002 are STILL status:proposed as of D25, a full week after D21 opened the chase -- this issue (#253) itself has sat In Progress that whole time. Week 6s opening note escalates this past the engineering-level chase (Navya raises it to platform architecture review as a named, dated blocker) before continuing the same local-placeholder pattern that has otherwise worked all week. Week 6 days: D26 escalate + draft 2 remaining IPD write-contracts (doctor-task, nursing-chart intake push), D27 wire TrayController + diet-order inbox list to HTTP, D28 tray label print + mobile scan (F3-7, no cross-team contract needed), D29 land the write-contracts or local-fallback them + draft attender opt-in read contract (F3-11), D30 checkpoint + sprints.md close-out + Week 7 only if needed.

sprints.md updated: F3-3/F3-7/F3-8/F3-11 point at Week 6; F3-5 notes the tray-round page; F4-4/F4-5 (DietChargeAccrual + running-bill post) marked shipped, pulled forward from Phase 4 since they only needed D22s already-built DietTypeCatalog/DietaryOrderSnapshot. clinq-docs branch docs/canteen-d22-sprints-update, PR #13 -> dev (still open, awaiting merge go-ahead -- now also carries the Week 6 plan).

Week 5 (D21-D25) is complete. 8 PRs open on nuvita-canteen-management (#5-#12), chained, none merged yet -- awaiting your review/merge decision. Redmine #253 stays In Progress: its own actual ask (ADR sign-off) has not happened; D26 Task 0 escalates it further.

Update, 2026-10-08 — Week 5 closed out, Week 6 (D26) starting.

Since the last update:

• Corrected ADR-0001/0002 status: proposed -> accepted. The team's actual sign-off process for
  a cross-repo dependency is "implement directly on a feature branch in the owning repo, no PR,
  no formal review gate" -- not silence. Both ADRs' draft implementations (real IPD/Admin
  branches, built 2026-10-06) already satisfied that process. sprints.md F0-D1/F0-D2 moved to done.
• Built the missing TrayController (GET round, POST plate/dispatch/deliver/collect) plus
  ITrayService.DispatchAsync/DeliverAsync -- closes the tray-round portal page's last gap.
  Found and fixed a real bug while wiring it: IAdmissionServiceContract had no DI registration
  at all, so TrayService failed to construct, 500ing every tray action (not just Plate as D24
  assumed). Added a local stub (UnimplementedAdmissionServiceClient) that fails loudly only when
  actually called.
• Fixed a real local-dev startup bug: AddPatientServiceClient throws if Emr:BaseUrl is unset;
  appsettings.json/.Development.json never had it configured, so the real API process was
  crashing on launch outside the test fixture. Added the missing config.
• Applied the 7 pending Dietary EF migrations to the clinq.local dev tenant (confirmed safe --
  Navya's own sandbox, not the shared eleven tenant) and seeded demo data (6 diet types, 4
  dietary orders, 6 trays, 2 dietitian assessments) for hospital 9.
• Diagnosed and fixed a stale-binary bug: this morning's dev stack had built from an old source
  snapshot missing Dashboard/Coupons/Reports/all of Dietary (route table had 57 endpoints instead
  of 74). Rebuilt and restarted the API from the correct integration/canteen-v1 source; confirmed
  via Swagger and a live browser session.
• Cleaned up repo state: merged the full Week 5 PR chain (#5-#13) into integration/canteen-v1,
  closed all 9 PRs with a note pointing to the merge commit, deleted all 18 now-fully-merged
  feature branches (local + remote), and removed the now-redundant .canteen-d23-worktree.

Week 5 (D21-D25) is fully complete. Corrected Week 6 plan is at
clinq-docs/modules/canteen-management/plans/2026-10-07-canteen-v1-week-6-tdd-plan.md (D26 Task 0,
the ADR escalation, is cancelled -- no longer needed). Starting D26 now: drafting the two
remaining IPD write-contracts (dietitian-recommendation-as-doctor-task, intake-%-to-nursing-chart).