Bug #153
open[HR][Verify] B-35: Credential-expired clinical staff not blocked by roster date; OPD booking unchecked
0%
Description
Credential blocking checks today's date, not the roster date, so blocked staff's existing roster entries still publish, and the OPD slot feed does no credential check at all, so a patient can book an unlicensed doctor. Reproduce: roster a doctor whose licence expires before the roster date and check the OPD booking feed. Part of #140.
SV Updated by Sravan V S about 2 months ago
- Assignee set to Sravan V S
S- Updated by SK - 12 days ago
- Status changed from New to Resolved
- Assignee changed from SK - to Roshni Harish.
- Resolved By set to SK -
Already fixed - confirmed live in current dev. This is the exact bug #140 fixed earlier today (per-date credential check at assign/publish/OPD-sync). Verified directly in the merged code: CredentialService.GetSchedulingBlockAsync/GetSchedulingBlockStatusesAsync now take an asOfDate parameter (defaulting to today only when not supplied), and RosterOpdSyncController passes the actual roster/booking date through - previously that endpoint had no credential check at all before this.
Marking resolved on the code side. The ticket's own repro ("roster a doctor whose licence expires before the roster date... check the OPD booking feed") is a live/deployed-box check - worth a QA pass on the test box once deployed, assigning to Roshni for that.
RH Updated by Roshni Harish. 3 days ago
- Assignee changed from Roshni Harish. to Sravan V S