Bug #707
openHR letters print raw placeholders: offer letter and leave approval letter
0%
Description
What happens:
The offer letter and the leave approval letter print raw placeholder text in the PDF instead of real values. The templates ask for values that HR never sends, and the renderer leaves unknown placeholders as they are.
Offer letter (template code offer-letter-permanent), HR > Employees > Generate offer letter:
- candidate name, candidate address, department, CTC, HR name and HR designation are not filled
- the printed letter reads like: Dear (placeholder), and the CTC line shows a placeholder after the rupee sign
Leave approval letter (template code leave-approval-letter), HR > Leave > approved request > Generate letter:
- the date at the top and the name of the approver are not filled
Payslip (template code payslip-staff) has the same problem for month, designation, basic, HRA and gross. Parked, because payroll is not being implemented soon.
Cause:
HR sends one fixed set of values for every letter (employee name and code, position title, hospital name, joining date, exit date, generated date) plus a few per letter. The templates use other names. See LetterService in nuvita-hr and the seed in nuvita-admin (DocumentTemplateSeedService).
Found by:
The Opus review of plan 1 of Feature #706. This is old behaviour, not caused by that work.
To decide before fixing:
- Who signs these letters (the name and designation to print for the HR signatory)?
- For the offer letter: which salary figure (the employee's annual CTC) and which department?
- For the leave letter: who approved it, and which date?
Then either HR sends the missing values, or the templates are changed to the names HR sends. Template content changes should wait until after the document-templates release (#706), which only adds rows.
No data to display