Feature #144
open[HR][P6] ESS shell
0%
Description
Profile menu with Change Password and a discoverable Logout in the ESS header (a working logout icon exists today at the bottom of the sidebar, but is easy to miss and there is no password change anywhere in ESS). Remove the dead bell/Help buttons or wire them up. Phone layout, profile link, badge counts.
Size: M
Needs owner decision #8 (see #137).
Source: clinq-docs/modules/hr/reviews/2026-09-28-ui-audit/ (branch docs/hr-ui-audit-2026-09-28)
Findings covered:
- A-02
- A-03
- A-08
- A-11
- A-07
- A-12
SV Updated by Sravan V S about 2 months ago
- Assignee set to Sravan V S
S- Updated by SK - 13 days ago
- Status changed from New to Resolved
- Assignee changed from SK - to Roshni Harish.
- Resolved By set to SK -
Fixed and merged to dev on nuvita-hr. Owner decision #8 (see #137) is already answered - share the module TopBar - so this ticket wasn't actually blocked.
Found the real gap precisely: HR's own admin shell had already migrated its header to the shared @nuvita-expericia/ui package TopBar (which already includes a profile menu with Change Password and Logout built in) - but the ESS header was explicitly left out of that earlier refactor. Closed that exact gap by switching ESS's header to the same shared component, which gives Change Password and Logout "for free" - no new auth code needed, Change Password is a deep-link to IAM like every other module already does.
- Confirmed both ticket claims before fixing: Logout only existed at the bottom of the ESS sidebar (easy to miss), and there was genuinely no Change Password surface anywhere in ESS.
- Confirmed the bell/Help buttons were genuinely dead (no onClick at all, same pattern already found and fixed elsewhere in HR for #141) - removed, since nothing in the backend exists for either to wire to.
- Fixed two real phone-width breakages: two header chips with no shrink protection that could squeeze out the rest of the header at narrow widths, and the ESS sidebar having no collapse affordance at all (unlike the HR admin shell, which already has one) - wired it to the same shared collapse mechanism.
- Checked the Leave Approvals badge count - confirmed already genuine, backed by a real API call, not stale/fake. No fix needed.
Not done, flagged: no browser/visual confirmation of the phone-width fix (reasoned from the actual layout code, not a screenshot - worth a quick manual check at 375px if you want visual confirmation). No separate "My Profile" menu item added beyond Change Password/Logout, since the shared component doesn't have one built in and /me/profile is already reachable from the sidebar - flag if you want that added too.
Tests: HR frontend 105/105 files, 818/818 tests passed, type-check clean. No backend change.
RH Updated by Roshni Harish. 3 days ago
- Assignee changed from Roshni Harish. to Sravan V S